zhouyuan commented on code in PR #9031:
URL: https://github.com/apache/incubator-gluten/pull/9031#discussion_r2000456404
##########
pom.xml:
##########
@@ -278,6 +278,7 @@
</activation>
<properties>
<java.version>1.8</java.version>
+ <iceberg.version>1.5.0</iceberg.version>
Review Comment:
> If we try to build with JD8 and Spark 355, iceberg should not be included.
The changes here don't seem necessary to me. Besides, we need to define
`iceberg.version` in spark config file instead of jdk config file so that we
can use different iceberg versions for different sparks.
+1
it seems we should not bind JDK version with iceberg version as this will
impact with Spark-344 also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
