WangGuangxin commented on code in PR #8606:
URL: https://github.com/apache/incubator-gluten/pull/8606#discussion_r2003333915
##########
backends-velox/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala:
##########
@@ -56,7 +55,9 @@ case class VeloxGetStructFieldTransformer(
child: ExpressionTransformer,
ordinal: Int,
original: GetStructField)
- extends UnaryExpressionTransformer {
+ extends BinaryExpressionTransformer {
Review Comment:
because we need to transform both `child` and `ordinal`, so the children
size should be two. Before this change, it doesn't need to transform `ordinal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
