zhztheplayer commented on code in PR #8986:
URL: https://github.com/apache/incubator-gluten/pull/8986#discussion_r2007299977
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -304,6 +304,18 @@ object VeloxConfig {
.booleanConf
.createWithDefault(true)
+ val MAX_PARTIAL_AGGREGATION_MEMORY =
+
buildConf("spark.gluten.sql.columnar.backend.velox.maxPartialAggregationMemory")
+ .internal()
+ .doc(
+ "Set the max memory of partial aggregation in bytes. When this option
is set to a " +
+ "value greater than 0, it will override
spark.gluten.sql.columnar.backend.velox." +
+ "maxPartialAggregationMemoryRatio. Note: this option only works when
flushable " +
+ "partial aggregation is enabled. Ignored when
spark.gluten.sql.columnar.backend." +
+ "velox.flushablePartialAggregation=false."
+ )
+ .bytesConf(ByteUnit.BYTE)
Review Comment:
Should it be
```
.byteConf(...)
.createOptional
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
