marin-ma commented on code in PR #9156:
URL: https://github.com/apache/incubator-gluten/pull/9156#discussion_r2016332730
##########
cpp/core/shuffle/LocalPartitionWriter.cc:
##########
@@ -387,7 +387,9 @@ std::string LocalPartitionWriter::nextSpilledFileDir() {
arrow::Result<std::shared_ptr<arrow::io::OutputStream>>
LocalPartitionWriter::openFile(const std::string& file) {
std::shared_ptr<arrow::io::FileOutputStream> fout;
- ARROW_ASSIGN_OR_RAISE(fout, arrow::io::FileOutputStream::Open(file));
+ auto fd = open(file.c_str(), O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR
| S_IRGRP | S_IROTH);
+ fchmod(fd, 0644);
Review Comment:
Could you add some comments here to indicate that it's intended to align the
file permissions with Spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
