zml1206 commented on code in PR #9153: URL: https://github.com/apache/incubator-gluten/pull/9153#discussion_r2017856663
########## gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala: ########## @@ -236,9 +235,6 @@ case class WholeStageTransformer(child: SparkPlan, materializeInput: Boolean = f val sparkConf: SparkConf = sparkContext.getConf - val serializableHadoopConf: SerializableConfiguration = new SerializableConfiguration( Review Comment: If serialization is require, `lazy` is a solution to avoid serialization without enabling viewFS, but if serialization is not needed here, it would be simpler to use `sparkContext.hadoopConfiguration` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
