taiyang-li commented on code in PR #9179:
URL: https://github.com/apache/incubator-gluten/pull/9179#discussion_r2022242696
##########
cpp-ch/local-engine/Functions/SparkParseURL.cpp:
##########
@@ -380,6 +380,21 @@ struct SparkExtractURLHost
if (userinfo_delim_pos && userinfo_delim_pos < end)
Review Comment:
instead of parsing url manually, why not use `Poco::URI`? It should be much
easier than current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
