baibaichen opened a new pull request, #9192:
URL: https://github.com/apache/incubator-gluten/pull/9192
## What changes were proposed in this pull request?
(Fixes: \#8846)
### Summary of Changes
This commit primarily:
1. Fixes directory name capitalization from "iceberg" to "Iceberg" across
the codebase
2. Reorganizes and improves include statements in several files
3. Adds new benchmark tests for Iceberg with delete operations
4. Makes minor code improvements and bug fixes
### Key Changes
#### Directory Structure and Naming
- Renamed `iceberg` directory to `Iceberg` with proper capitalization
- Updated all include paths to reflect this change
- Updated CMakeLists.txt to use the new capitalized directory name
#### Code Improvements
- Fixed typo: `begion` → `begin` in BlockTypeUtils.h
- Added assertion to verify input_format is not null in `NormalFileReader`
constructor
- Improved readability of DeltaReader::create by splitting a long line
- Simplified row counting in ParquetFormatFile.cpp using
`std::ranges::fold_left`
- Added null check before using input in IcebergReader::create
#### New Functionality: Added code for benchmarking Iceberg read operations
with equality deletes and position deletes
```
Run on (24 X 1285.69 MHz CPU s)
CPU Caches:
L1 Data 48 KiB (x12)
L1 Instruction 32 KiB (x12)
L2 Unified 1280 KiB (x12)
L3 Unified 30720 KiB (x1)
Load Average: 2.34, 1.91, 2.30
----------------------------------------------------------------------------------------------
Benchmark Time
CPU Iterations
----------------------------------------------------------------------------------------------
BM_IcebergReadWithPositionDeletes/0/iterations:10 39.3 ms
39.3 ms 10
BM_IcebergReadWithPositionDeletes/1/iterations:10 156 ms
155 ms 10
BM_IcebergReadWithPositionDeletes/10/iterations:10 148 ms
145 ms 10
BM_IcebergReadWithPositionDeletes/50/iterations:10 273 ms
267 ms 10
BM_IcebergReadWithPositionDeletes/100/iterations:10 347 ms
335 ms 10
BM_IcebergReadWithEqualityDeletes/0/iterations:10 36.8 ms
36.8 ms 10
BM_IcebergReadWithEqualityDeletes/1/iterations:10 192 ms
191 ms 10
BM_IcebergReadWithEqualityDeletes/5/iterations:10 617 ms
616 ms 10
BM_IcebergReadWithEqualityDeletes/10/iterations:10 1821 ms
1817 ms 10
BM_IcebergReadWithEqualityDeletes/50/iterations:10 9716 ms
9703 ms 10
```
## How was this patch tested?
Existed UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
