marin-ma commented on code in PR #8952:
URL: https://github.com/apache/incubator-gluten/pull/8952#discussion_r2027229120
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala:
##########
@@ -118,8 +119,13 @@ trait ValidatablePlan extends GlutenPlan with LogLevelUtil
{
if (!validationResult.ok()) {
TestStats.addFallBackClassName(this.getClass.toString)
}
- if (validationFailFast) validationResult
- else ValidationResult.merge(schemaValidationResult, validationResult)
+ val result =
+ if (validationFailFast) validationResult
+ else ValidationResult.merge(schemaValidationResult, validationResult)
+ if (!result.ok()) {
+ logOnLevel(glutenConf.validationLogLevel, result.reason())
Review Comment:
There are duplicated validation logs with this change, one is reported by
the original operator, the other one is reported by `GlutenFallbackReporter`.
Can we keep only one of them?
The duplicated log looks like:
```
16:04:16.757 WARN org.apache.gluten.execution.ProjectExecTransformer:
- Native validation failed:
|- Validation failed at file:SubstraitToVeloxPlanValidator.cc, line:304,
function:validateCast, reason:Casting from ARRAY<UNKNOWN> to ARRAY<VARCHAR> is
not supported.
16:04:16.757 WARN org.apache.spark.sql.execution.GlutenFallbackReporter:
Validation failed for plan: Project[QueryId=122], due to:
- Native validation failed:
|- Validation failed at file:SubstraitToVeloxPlanValidator.cc, line:304,
function:validateCast, reason:Casting from ARRAY<UNKNOWN> to ARRAY<VARCHAR> is
not supported.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
