PHILO-HE commented on code in PR #8911:
URL: https://github.com/apache/incubator-gluten/pull/8911#discussion_r2034296838
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/GlutenAutoAdjustStageResourceProfile.scala:
##########
@@ -88,6 +88,11 @@ case class GlutenAutoAdjustStageResourceProfile(glutenConf:
GlutenConfig, spark:
val newExecutorMemory =
new ExecutorResourceRequest(ResourceProfile.MEMORY,
newMemoryAmount.toLong)
executorResource.put(ResourceProfile.MEMORY, newExecutorMemory)
+
+ val newExecutorOffheap =
+ new ExecutorResourceRequest(ResourceProfile.OFFHEAP_MEM,
offheapRequest.get.amount / 10)
Review Comment:
@JkSelf, let's first use this empirical fixed setting and wait for feedback
from user side. In theory, user don't need to configure too much offheap memory
in stage fallback case. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
