zhztheplayer commented on code in PR #9229:
URL: https://github.com/apache/incubator-gluten/pull/9229#discussion_r2042316950
##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -1716,4 +1717,11 @@ object GlutenConfig {
.booleanConf
.createWithDefault(true)
+ val COLUMNAR_CUDF_ENABLED =
+ buildConf("spark.gluten.sql.columnar.cudf")
+ .internal()
+ .doc("Enable or disable cudf support.")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
Several questions:
1. Could we add an "experimental" mark in the option `doc()`?
2. Should we turn it off by default?
3. What happens from user side if CPP code is not built with `--enable_gpu`
but this option is turned on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
