JkSelf commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2046448705
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -532,6 +535,16 @@ object VeloxConfig {
.booleanConf
.createWithDefault(false)
+ val VELOX_BROADCAST_BUILD_HASHTABLE_ONCE_PER_EXECUTOR =
+ buildConf("spark.gluten.velox.buildHashTableOncePerExecutor.enabled")
+ .internal()
+ .doc(
+ "Experimental: When enabled, the hash table is " +
+ "constructed once per executor. If not enabled, " +
+ "the hash table is rebuilt for each task.")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
@zhztheplayer We plan to enable this feature by default, as we have
successfully passed all unit tests except for this one
https://github.com/apache/incubator-gluten/issues/9342.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
