ArnavBalyan commented on code in PR #9074:
URL: https://github.com/apache/incubator-gluten/pull/9074#discussion_r2056216443
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala:
##########
@@ -137,6 +137,7 @@ object Validators {
case p: CartesianProductExec if !settings.supportCartesianProductExec()
=> fail(p)
case p: TakeOrderedAndProjectExec if
!settings.supportColumnarShuffleExec() => fail(p)
case p: CollectLimitExec if !settings.supportCollectLimitExec() =>
fail(p)
+ case p: CollectTailExec if !settings.supportCollectTailExec() => fail(p)
Review Comment:
No, would the fallback tag be applied/required if CollectTailTransformerRule
does not transform?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
