kevinw66 commented on code in PR #8982: URL: https://github.com/apache/incubator-gluten/pull/8982#discussion_r2057221324
########## dev/vcpkg/triplets/arm64-linux-neon.cmake: ########## @@ -0,0 +1,10 @@ +set(VCPKG_BUILD_TYPE release) +set(VCPKG_TARGET_ARCHITECTURE arm64) +set(VCPKG_CRT_LINKAGE dynamic) +set(VCPKG_LIBRARY_LINKAGE static) + +set(VCPKG_CMAKE_SYSTEM_NAME Linux) + +set(VCPKG_C_FLAGS "-march=armv8-a+crc ") +set(VCPKG_CXX_FLAGS "-march=armv8-a+crc -std=c++17 ") Review Comment: @zmdaodao Could you help remove the extra white spaces in these 3 places? ``` set(VCPKG_CMAKE_SYSTEM_NAME Linux)[white space] set(VCPKG_C_FLAGS "-march=armv8-a+crc[white space]") set(VCPKG_CXX_FLAGS "-march=armv8-a+crc -std=c++17[white space]") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
