taiyang-li commented on code in PR #9139:
URL: https://github.com/apache/incubator-gluten/pull/9139#discussion_r2057941133
##########
backends-clickhouse/src/main/java/org/apache/gluten/vectorized/CHNativeBlock.java:
##########
@@ -111,4 +117,14 @@ public ColumnarBatch toColumnarBatch() {
}
return new ColumnarBatch(vectors, numRows);
}
+
+ public static ColumnarBatch slice(ColumnarBatch batch, int offset, int
limit) {
+ if (limit >= batch.numRows()) {
Review Comment:
what if both limit and offset exceed batch.numRows() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
