JkSelf commented on issue #9342: URL: https://github.com/apache/incubator-gluten/issues/9342#issuecomment-2862157628
The pull request at https://github.com/apache/incubator-gluten/pull/8931 is designed to release the hash table upon receiving the SparkListenerSQLExecutionEnd event. However, when executing the failed unit test found at https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala#L322, we observed that Gluten receives the SparkListenerSQLExecutionEnd event after the code segment at https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala#L295-L306 is executed. This sequence results in the hash table being released prematurely. Consequently, the code at https://github.com/apache/incubator-gluten/pull/8931/files#diff-7943f791e0bc3501ea8b79d0d17815f6baea22e32ee101c1e410269ec9997ad0R48 is executed after the hash table has been released, leading to its continued use in Velox's HashBuild, which causes issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
