marin-ma commented on code in PR #9766:
URL: https://github.com/apache/incubator-gluten/pull/9766#discussion_r2113264397
##########
cpp/velox/shuffle/VeloxSortShuffleWriter.cc:
##########
@@ -160,7 +160,7 @@ arrow::Status VeloxSortShuffleWriter::insert(const
facebook::velox::RowVectorPtr
facebook::velox::row::CompactRow row(vector);
if (fixedRowSize_.has_value()) {
- rowSize_.resize(inputRows, fixedRowSize_.value() + sizeof(RowSizeType));
+ rowSize_.resize(inputRows, fixedRowSize_.value());
Review Comment:
rowSize_ was wrong for fixed-widths input. It was over calculated by 4 bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
