zhztheplayer commented on PR #8987: URL: https://github.com/apache/incubator-gluten/pull/8987#issuecomment-2949850325
I just bumped into this PR. There are two issues that I experienced: 1. The `GlutenTest...` tests are informal regarding junit's naming conventions, this could cause the tests not run in some cases. Naming them with `TestGluten` will solve the issue. I'll suggest double-checking whether the tests are actually being run in our CI. 2. The tests are under a package named `org.apache.gluten.spark34`, but the compilation is triggered for every Spark version. This makes compilation fail on other Spark versions. E.g., `-P spark-3.2,iceberg,backends-velox` cc @jinchengchenghh see if you could take a look once available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
