RushabhK commented on code in PR #9808:
URL: https://github.com/apache/incubator-gluten/pull/9808#discussion_r2137360227
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/SparkWriteFilesCommitProtocol.scala:
##########
@@ -97,8 +97,11 @@ class SparkWriteFilesCommitProtocol(
}
}
- def abortTask(): Unit = {
+ def abortTask(writePath: String): Unit = {
committer.abortTask(taskAttemptContext)
+
+ val tmpPath = new Path(writePath)
Review Comment:
@JkSelf This would delete all the files in the temporary staging directory.
This leads to FileNotFoundException, I have seen this in my setup:
https://github.com/apache/incubator-gluten/issues/9801#issuecomment-2929038203
We need to selectively delete the files like spark's
HadoopMapReduceCommitProtocol selectively deletes the absolute paths that were
added:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala#L302-L305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
