zhztheplayer commented on code in PR #8930:
URL: https://github.com/apache/incubator-gluten/pull/8930#discussion_r2156405041
##########
pom.xml:
##########
@@ -1637,6 +1653,14 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <skipTests>true</skipTests>
+ </configuration>
Review Comment:
I just run some local tests around [the commit
before](https://github.com/apache/incubator-gluten/commits/6ece721b1a058a5434be5ccdf82c6f35cb5c1ef2)
and [the commit
after](https://github.com/apache/incubator-gluten/commits/82e4eee8c7e61048365dede2a98a45ceafe828b4)
this PR.
My command used was `mvn clean install -P spark-3.4 -pl gluten-core -am` and
the behavior did seem changed between the commits... The Java tests were run
before but weren't after.
> This surefire plugin was only added in some submodules.
I guess the Java tests used to run because Maven doesn't require
specifically adding a `maven-surefire-plugin` for them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
