zhztheplayer commented on code in PR #9397:
URL: https://github.com/apache/incubator-gluten/pull/9397#discussion_r2176295082
##########
gluten-core/src/main/resources/org/apache/gluten/proto/IcebergPartitionSpec.proto:
##########
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: Apache-2.0
+syntax = "proto3";
+
+package gluten;
+
+option java_package = "org.apache.gluten.proto";
+option java_multiple_files = true;
+
+enum TransformType {
+ IDENTITY = 0;
+ YEAR = 1;
+ MONTH = 2;
+ DAY = 3;
+ HOUR = 4;
+ BUCKET = 5;
+ TRUNCATE = 6;
+}
+
+message IcebergPartitionField {
+ string name = 1;
+ TransformType transform = 2;
+ optional int32 parameter = 3; // Optional parameter for transform config
+}
+
+message IcebergPartitionSpec {
+ int32 spec_id = 1; // Field name uses snake_case per protobuf conventions
+ repeated IcebergPartitionField fields = 2;
+}
Review Comment:
Possible to move to gluten-substrait or backend-velox? Thanks!
I understand it doesn't belong to the substrait protos but still it doesn't
seem general to place here.
##########
dev/builddeps-veloxbe.sh:
##########
@@ -7,7 +7,7 @@
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
-# http://www.apache.org/licenses/LICENSE-2.0
+# http://www.apache.org/licenses/LICENSE-2.0C
Review Comment:
is this intentional?
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -20,8 +20,8 @@ VELOX_REPO=https://github.com/oap-project/velox.git
VELOX_BRANCH=2025_06_25
VELOX_HOME=""
RUN_SETUP_SCRIPT=ON
-VELOX_ENHANCED_REPO=https://github.com/oap-project/velox.git
-VELOX_ENHANCED_BRANCH=2025_06_24
+VELOX_ENHANCED_REPO=https://github.com/jinchengchenghh/velox.git
+VELOX_ENHANCED_BRANCH=2025_06_25
Review Comment:
I have no strong opinion on this, but as long as there are no objections
from everybody.
Are you going to change the repo to `ibm/velox` right in the next PR?
##########
.github/workflows/velox_backend_enhanced_features.yml:
##########
@@ -0,0 +1,170 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Velox backend Github Runner (Enhanced Features)
+
+on:
+ pull_request:
+ paths:
+ - '.github/workflows/velox_backend_enhanced_features.yml'
+ - 'pom.xml'
+ - 'backends-velox/**'
+ - 'gluten-uniffle/**'
+ - 'gluten-celeborn/**'
+ - 'gluten-ras/**'
+ - 'gluten-core/**'
+ - 'gluten-substrait/**'
+ - 'gluten-arrow/**'
+ - 'gluten-delta/**'
+ - 'gluten-iceberg/**'
+ - 'gluten-hudi/**'
+ - 'gluten-ut/**'
+ - 'shims/**'
+ - 'tools/gluten-it/**'
+ - 'ep/build-velox/**'
+ - 'cpp/**'
+ - 'dev/**'
+
+env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+ MVN_CMD: 'mvn -ntp'
+ WGET_CMD: 'wget -nv'
+ SETUP: 'bash .github/workflows/util/setup_helper.sh'
+ CCACHE_DIR: "${{ github.workspace }}/.ccache"
+ # for JDK17 unit tests
+ EXTRA_FLAGS: "-XX:+IgnoreUnrecognizedVMOptions
+ --add-opens=java.base/java.lang=ALL-UNNAMED
+ --add-opens=java.base/java.lang.invoke=ALL-UNNAMED
+ --add-opens=java.base/java.lang.reflect=ALL-UNNAMED
+ --add-opens=java.base/java.io=ALL-UNNAMED
+ --add-opens=java.base/java.net=ALL-UNNAMED
+ --add-opens=java.base/java.nio=ALL-UNNAMED
+ --add-opens=java.base/java.util=ALL-UNNAMED
+ --add-opens=java.base/java.util.concurrent=ALL-UNNAMED
+ --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
+ --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED
+ --add-opens=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-opens=java.base/sun.nio.cs=ALL-UNNAMED
+ --add-opens=java.base/sun.security.action=ALL-UNNAMED
+ --add-opens=java.base/sun.util.calendar=ALL-UNNAMED
+ -Djdk.reflect.useDirectMethodHandle=false
+ -Dio.netty.tryReflectionSetAccessible=true"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+jobs:
+ build-native-lib-centos-7:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-enhanced-centos7-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-enhanced-centos7-release-default
+ - name: Build Gluten native libraries
+ run: |
+ docker pull apache/gluten:vcpkg-centos-7
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-7 bash -c "
+ set -e
+ yum install tzdata -y
+ df -a
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ mkdir -p /work/.ccache
+ bash dev/ci-velox-buildstatic-centos-7-enhanced-features.sh
+ ccache -s
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
+ "
+
+ - name: "Save ccache"
+ uses: actions/cache/save@v4
+ id: ccache
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-enhanced-centos7-release-default-${{github.sha}}
+ - uses: actions/upload-artifact@v4
+ with:
+ name: velox-native-lib-enhanced-centos-7-${{github.sha}}
+ path: ./cpp/build/releases/
+ if-no-files-found: error
+ - uses: actions/upload-artifact@v4
+ with:
+ name: arrow-jars-enhanced-centos-7-${{github.sha}}
+ path: .m2/repository/org/apache/arrow/
+ if-no-files-found: error
+
+ spark-test-spark34:
Review Comment:
Can we include Spark 3.5 as well? As long as there's no technical blockers
it's better to have the lasted Spark version covered in test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
