jinchengchenghh commented on code in PR #10119: URL: https://github.com/apache/incubator-gluten/pull/10119#discussion_r2184556366
########## cpp/velox/config/VeloxConfig.h: ########## @@ -69,6 +69,10 @@ const std::string kVeloxSplitPreloadPerDriver = "spark.gluten.sql.columnar.backe const std::string kShowTaskMetricsWhenFinished = "spark.gluten.sql.columnar.backend.velox.showTaskMetricsWhenFinished"; const bool kShowTaskMetricsWhenFinishedDefault = false; +const std::string kTaskMetricsToEventLogThreshold = Review Comment: Could you add the config to VeloxConfig.scala? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
