PHILO-HE opened a new pull request, #10243:
URL: https://github.com/apache/incubator-gluten/pull/10243

   ## What changes were proposed in this pull request?
   
   Fix issue reported here: 
https://github.com/apache/incubator-gluten/issues/10102#issuecomment-3095015236.
   
   The build information is added in two places during the compile phase: 
`gluten-core/pom.xml` and `gluten-substrait/pom.xml`. And they both modify 
`gluten-build-info.properties` placed in gluten-core's resource path: 
`gluten-core/target/generated-resources/`.
   
   When building module gluten-core, the generated resources will be copy into 
target/classes/ and then be packed into module jar. In the later build for 
module gluten-substrait, the backend related build info is just added in the 
property file under gluten-core's resource path. And at the final package phase 
for the project, the shade plugin just packs classes and resource files inside 
module jars, not considering a module's resource path, which means the later 
added build info is not actually covered by the property file inside Gluten fat 
jar.
   
   In this pr, gluten-core's resource file is included in package module, and a 
configuration is added for shade plugin to exclude the property file comes from 
gluten-core jar.
   
   ## How was this patch tested?
   
   Check in local test.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to