PHILO-HE commented on code in PR #10125:
URL:
https://github.com/apache/incubator-gluten/pull/10125#discussion_r2238597068
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/BaseRexCallConverters.java:
##########
@@ -62,6 +63,16 @@ public DefaultRexCallConverter(String functionName) {
public TypedExpr toTypedExpr(RexCall callNode, RexConversionContext context)
{
List<TypedExpr> params = getParams(callNode, context);
Type resultType = getResultType(callNode);
+
+ if ("cast".equals(functionName) && params.size() == 1) {
+ TypedExpr sourceExpr = params.get(0);
+ Type sourceType = sourceExpr.getReturnType();
+
+ if (sourceType instanceof TimestampType && resultType instanceof
TimestampType) {
Review Comment:
For decimal type, "same" means the two types have same precision and scale.
Then, no precision loss?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
