zml1206 commented on code in PR #10270:
URL:
https://github.com/apache/incubator-gluten/pull/10270#discussion_r2244225240
##########
gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala:
##########
@@ -43,69 +43,6 @@ class GlutenCastSuite extends CastSuite with
GlutenTestsTrait {
UDTRegistration.register(classOf[IExampleBaseType].getName,
classOf[ExampleBaseTypeUDT].getName)
UDTRegistration.register(classOf[IExampleSubType].getName,
classOf[ExampleSubTypeUDT].getName)
- test("cast array element from integer to string") {
Review Comment:
@PHILO-HE Do you have any other comments? I would like to quickly support
`cast(array as string)` based on this, velox does not support cast Array to
String. I will add rule to replace `cast(array as String)` with `concat('[',
array_join(array, ', ', 'null'), ']')` to support offload. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
