FelixYBW commented on code in PR #10294:
URL: 
https://github.com/apache/incubator-gluten/pull/10294#discussion_r2278514478


##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxMetricsApi.scala:
##########
@@ -96,6 +96,13 @@ class VeloxMetricsApi extends MetricsApi with Logging {
       "skippedSplits" -> SQLMetrics.createMetric(sparkContext, "number of 
skipped splits"),
       "processedSplits" -> SQLMetrics.createMetric(sparkContext, "number of 
processed splits"),
       "preloadSplits" -> SQLMetrics.createMetric(sparkContext, "number of 
preloaded splits"),
+      "pageLoadTime" -> SQLMetrics.createNanoTimingMetric(sparkContext, "page 
load time"),
+      "dataSourceAddSplitTime" -> SQLMetrics.createNanoTimingMetric(
+        sparkContext,
+        "data source add split time"),

Review Comment:
   change to `add split time`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to