This is an automated email from the ASF dual-hosted git repository.
taiyangli pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 3343cb4238 [GLUTEN-10555] Remove unnecessary parameter
leafTransformers for WholeStageTransformer (#10556)
3343cb4238 is described below
commit 3343cb4238d12cf8876d50582959b8fd93fdd7cf
Author: Jiaan Geng <[email protected]>
AuthorDate: Thu Aug 28 11:07:46 2025 +0800
[GLUTEN-10555] Remove unnecessary parameter leafTransformers for
WholeStageTransformer (#10556)
---
.../apache/gluten/execution/WholeStageTransformer.scala | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git
a/gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala
b/gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala
index 554ff910eb..abe841f998 100644
---
a/gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala
+++
b/gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala
@@ -276,13 +276,11 @@ case class WholeStageTransformer(child: SparkPlan,
materializeInput: Boolean = f
private def findAllLeafTransformers(): Seq[LeafTransformSupport] = {
val allLeafTransformers = new mutable.ListBuffer[LeafTransformSupport]()
- def transformChildren(
- plan: SparkPlan,
- leafTransformers: mutable.ListBuffer[LeafTransformSupport]): Unit = {
+ def transformChildren(plan: SparkPlan): Unit = {
if (plan != null && plan.isInstanceOf[TransformSupport]) {
plan match {
case transformer: LeafTransformSupport =>
- leafTransformers.append(transformer)
+ allLeafTransformers.append(transformer)
case _ =>
}
@@ -290,16 +288,15 @@ case class WholeStageTransformer(child: SparkPlan,
materializeInput: Boolean = f
// SHJ may include two leaves in a whole stage.
plan match {
case shj: HashJoinLikeExecTransformer =>
- transformChildren(shj.streamedPlan, leafTransformers)
- transformChildren(shj.buildPlan, leafTransformers)
+ transformChildren(shj.streamedPlan)
+ transformChildren(shj.buildPlan)
case t: TransformSupport =>
- t.children
- .foreach(transformChildren(_, leafTransformers))
+ t.children.foreach(transformChildren(_))
}
}
}
- transformChildren(child, allLeafTransformers)
+ transformChildren(child)
allLeafTransformers.toSeq
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
