zjuwangg commented on PR #10561: URL: https://github.com/apache/incubator-gluten/pull/10561#issuecomment-3232485455
> @zjuwangg, It makes sense to fix this since both Java 11 and 17 are supported. Setting maven.compiler.source/target to 17 would cause compatibility issues when building Gluten Flink with Java 11. > > I think we can add a profile named java-17 to set both properties to 17 (defaults to 11) if users want to build the code with Java 17. This approach is different from setting the compiler properties to 11 while building with Java 17, as it enables Java 17 features. As you mentioned, velox4j is compiled with Java 11, but it should work when running on a Java 17 JVM due to Java's backward compatibility. Therefore, I assume we don't need to hardcode the compiler source and target properties to 11. @PHILO-HE Really make sense to me. Will add a jdk17 compile profile soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
