zjuwangg commented on code in PR #10603:
URL:
https://github.com/apache/incubator-gluten/pull/10603#discussion_r2318185214
##########
gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -1172,68 +1128,54 @@ object GlutenConfig {
val COLUMNAR_MEMORY_BACKTRACE_ALLOCATION =
buildConf("spark.gluten.memory.backtrace.allocation")
- .internal()
- .doc("Print backtrace information for large memory allocations. This
helps debugging when " +
- "Spark OOM happens due to large acquire requests.")
+ .doc(
+ "Print backtrace information for large memory allocations. This helps
debugging when " +
+ "Spark OOM happens due to large acquire requests.")
.booleanConf
.createWithDefault(false)
val TRANSFORM_PLAN_LOG_LEVEL =
- buildConf("spark.gluten.sql.transform.logLevel")
- .internal()
- .stringConf
+ buildConf("spark.gluten.sql.transform.logLevel").stringConf
.transform(_.toUpperCase(Locale.ROOT))
.checkValue(
logLevel => Set("TRACE", "DEBUG", "INFO", "WARN",
"ERROR").contains(logLevel),
"Valid values are 'trace', 'debug', 'info', 'warn' and 'error'.")
.createWithDefault("DEBUG")
val SUBSTRAIT_PLAN_LOG_LEVEL =
- buildConf("spark.gluten.sql.substrait.plan.logLevel")
- .internal()
- .stringConf
+ buildConf("spark.gluten.sql.substrait.plan.logLevel").stringConf
.transform(_.toUpperCase(Locale.ROOT))
.checkValue(
logLevel => Set("TRACE", "DEBUG", "INFO", "WARN",
"ERROR").contains(logLevel),
"Valid values are 'trace', 'debug', 'info', 'warn' and 'error'.")
.createWithDefault("DEBUG")
val VALIDATION_LOG_LEVEL =
- buildConf("spark.gluten.sql.validation.logLevel")
- .internal()
- .stringConf
+ buildConf("spark.gluten.sql.validation.logLevel").stringConf
.transform(_.toUpperCase(Locale.ROOT))
.checkValue(
logLevel => Set("TRACE", "DEBUG", "INFO", "WARN",
"ERROR").contains(logLevel),
"Valid values are 'trace', 'debug', 'info', 'warn' and 'error'.")
.createWithDefault("WARN")
val VALIDATION_PRINT_FAILURE_STACK =
- buildConf("spark.gluten.sql.validation.printStackOnFailure")
- .internal()
- .booleanConf
+ buildConf("spark.gluten.sql.validation.printStackOnFailure").booleanConf
.createWithDefault(false)
val VALIDATION_FAIL_FAST =
- buildConf("spark.gluten.sql.validation.failFast")
- .internal()
- .booleanConf
+ buildConf("spark.gluten.sql.validation.failFast").booleanConf
.createWithDefault(true)
val SOFT_AFFINITY_LOG_LEVEL =
- buildConf("spark.gluten.soft-affinity.logLevel")
- .internal()
- .stringConf
+ buildConf("spark.gluten.soft-affinity.logLevel").stringConf
.transform(_.toUpperCase(Locale.ROOT))
.checkValue(
logLevel => Set("TRACE", "DEBUG", "INFO", "WARN",
"ERROR").contains(logLevel),
"Valid values are 'trace', 'debug', 'info', 'warn' and 'error'.")
.createWithDefault("DEBUG")
val DEBUG_ENABLED =
- buildConf("spark.gluten.sql.debug")
- .internal()
- .booleanConf
+ buildConf("spark.gluten.sql.debug").booleanConf
Review Comment:
@PHILO-HE Agreed.
I think we can review `internal()` method and add `experimental()` method
to gluten config. Also we can add `version()` like Spark does to make config
more explainable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
