zhouyuan commented on code in PR #10585:
URL:
https://github.com/apache/incubator-gluten/pull/10585#discussion_r2321463485
##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -91,8 +91,8 @@ void veloxRuntimeReleaser(Runtime* runtime) {
void VeloxBackend::init(
std::unique_ptr<AllocationListener> listener,
const std::unordered_map<std::string, std::string>& conf) {
- backendConf_ =
-
std::make_shared<facebook::velox::config::ConfigBase>(std::unordered_map<std::string,
std::string>(conf));
+ backendConf_ = std::make_shared<facebook::velox::config::ConfigBase>(
Review Comment:
No, here `veloxCfg_` contains only session level configurations, it does not
cover the configurations defined in spark.conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
