This is an automated email from the ASF dual-hosted git repository.
yuanzhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new abb1ebb501 [GLUTEN-6887][VL] Daily Update Velox Version (2025_09_06)
(#10643)
abb1ebb501 is described below
commit abb1ebb501491af042944f088193ef56820504e3
Author: Gluten Performance Bot
<[email protected]>
AuthorDate: Sat Sep 6 21:31:27 2025 +0100
[GLUTEN-6887][VL] Daily Update Velox Version (2025_09_06) (#10643)
* [GLUTEN-6887][VL] Daily Update Velox Version (2025_09_06)
Upstream Velox's New Commits:
2cac6c685 by Devavret Makkar, feat(cudf): Add support for Nested precompute
expressions cardinality and split (#14462)
1aff02aae by Daniel Munoz, misc: Update runtime metrics documentation
(#14751)
99a04b94e by Jialiang Tan, misc: Remove SerializedPageSpiller related
code/1 (#14683)
d70eec6f0 by Masha Basmanova, feat: Allow adding per-node context to plan
summary (#14742)
3f7a211f3 by Chengcheng Jin, feat(iceberg): Add bucket function (#13174)
2599eef30 by dependabot[bot], build(deps): Bump http-proxy-middleware from
2.0.7 to 2.0.9 in /website (#14708)
d8433ba5e by Sutou Kouhei, fix(build): Fix wrong link target for
velox_dwio_text_reader (#14674)
3721fe85e by Ke Jia, fix: Enable S3 and GCS unit tests (#14718)
c12e666f8 by Mahadevuni Naveen Kumar, fix: Aggregate destroyAccumulator
memset call with dynamic class input (#14568)
Signed-off-by: glutenperfbot <[email protected]>
* fix memory manager api
Signed-off-by: Yuan <[email protected]>
fix
Signed-off-by: Yuan <[email protected]>
fix
Signed-off-by: Yuan <[email protected]>
---------
Signed-off-by: glutenperfbot <[email protected]>
Signed-off-by: Yuan <[email protected]>
Co-authored-by: glutenperfbot <[email protected]>
Co-authored-by: Yuan <[email protected]>
---
cpp/velox/compute/VeloxBackend.cc | 4 +++-
cpp/velox/memory/VeloxMemoryManager.cc | 16 ++++++++--------
ep/build-velox/src/get_velox.sh | 4 ++--
3 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/cpp/velox/compute/VeloxBackend.cc
b/cpp/velox/compute/VeloxBackend.cc
index d8089d8653..04faab8f3a 100644
--- a/cpp/velox/compute/VeloxBackend.cc
+++ b/cpp/velox/compute/VeloxBackend.cc
@@ -210,7 +210,9 @@ void VeloxBackend::init(
memoryManagerCapacity = facebook::velox::memory::kMaxMemory;
}
LOG(INFO) << "Setting global Velox memory manager with capacity: " <<
memoryManagerCapacity;
- facebook::velox::memory::initializeMemoryManager({.allocatorCapacity =
memoryManagerCapacity});
+ facebook::velox::memory::MemoryManager::Options options;
+ options.allocatorCapacity = memoryManagerCapacity;
+ facebook::velox::memory::initializeMemoryManager(options);
// local cache persistent relies on the cache pool from root memory pool so
we need to init this
// after the memory manager instanced
diff --git a/cpp/velox/memory/VeloxMemoryManager.cc
b/cpp/velox/memory/VeloxMemoryManager.cc
index 840f4ca795..ec568fa6a6 100644
--- a/cpp/velox/memory/VeloxMemoryManager.cc
+++ b/cpp/velox/memory/VeloxMemoryManager.cc
@@ -234,14 +234,14 @@ VeloxMemoryManager::VeloxMemoryManager(
auto checkUsageLeak = backendConf.get<bool>(kCheckUsageLeak,
kCheckUsageLeakDefault);
ArbitratorFactoryRegister afr(listener_.get());
- velox::memory::MemoryManagerOptions mmOptions{
- .alignment = velox::memory::MemoryAllocator::kMaxAlignment,
- .trackDefaultUsage = true, // memory usage tracking
- .checkUsageLeak = checkUsageLeak, // leak check
- .coreOnAllocationFailureEnabled = false,
- .allocatorCapacity = velox::memory::kMaxMemory,
- .arbitratorKind = afr.getKind(),
- .extraArbitratorConfigs = getExtraArbitratorConfigs(backendConf)};
+ velox::memory::MemoryManager::Options mmOptions;
+ mmOptions.alignment = velox::memory::MemoryAllocator::kMaxAlignment;
+ mmOptions.trackDefaultUsage = true; // memory usage tracking
+ mmOptions.checkUsageLeak = checkUsageLeak; // leak check
+ mmOptions.coreOnAllocationFailureEnabled = false;
+ mmOptions.allocatorCapacity = velox::memory::kMaxMemory;
+ mmOptions.arbitratorKind = afr.getKind();
+ mmOptions.extraArbitratorConfigs = getExtraArbitratorConfigs(backendConf);
veloxMemoryManager_ =
std::make_unique<velox::memory::MemoryManager>(mmOptions);
veloxAggregatePool_ = veloxMemoryManager_->addRootPool(
diff --git a/ep/build-velox/src/get_velox.sh b/ep/build-velox/src/get_velox.sh
index 2cd3180018..76696022ea 100755
--- a/ep/build-velox/src/get_velox.sh
+++ b/ep/build-velox/src/get_velox.sh
@@ -17,11 +17,11 @@
set -exu
VELOX_REPO=https://github.com/oap-project/velox.git
-VELOX_BRANCH=2025_09_04
+VELOX_BRANCH=2025_09_06
VELOX_HOME=""
RUN_SETUP_SCRIPT=ON
VELOX_ENHANCED_REPO=https://github.com/IBM/velox.git
-VELOX_ENHANCED_BRANCH=ibm-2025_09_04
+VELOX_ENHANCED_BRANCH=ibm-2025_09_06
ENABLE_ENHANCED_FEATURES=OFF
# Developer use only for testing Velox PR.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
