Zouxxyy commented on code in PR #10647:
URL:
https://github.com/apache/incubator-gluten/pull/10647#discussion_r2328449994
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -242,8 +230,16 @@ if [[ "$RUN_SETUP_SCRIPT" == "ON" ]]; then
echo "Unsupported kernel: $OS"
exit 1
fi
+}
+
+prepare_velox_source_code
+
+if [[ "$RUN_SETUP_SCRIPT" == "ON" ]]; then
Review Comment:
Actually, I don't think it's necessary to pass `RUN_SETUP_SCRIPT` here. If
we have a brand new velox, we should just apply the setup fixes as we apply
other patches or fixes. (Once is enough)
Then the user can repeatedly execute `.builddeps-veloxbe.sh
setup_dependencies`, because setup generally needs to be executed repeatedly in
a new environment (my experience)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
