zjuwangg commented on code in PR #10634:
URL:
https://github.com/apache/incubator-gluten/pull/10634#discussion_r2354747315
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -545,6 +545,20 @@ object VeloxConfig {
.booleanConf
.createWithDefault(false)
+ val VELOX_HASHMAP_ABANDON_BUILD_DUPHASH_MIN_ROWS =
+ buildConf("spark.gluten.velox.abandonbuild.noduphashminrows")
+ .internal()
+ .doc("Experimental: abandon hashmap build if duplicated rows more than
this number.")
Review Comment:
Should add experimental() method and re-generate configuration doc if
needed.
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -545,6 +545,20 @@ object VeloxConfig {
.booleanConf
.createWithDefault(false)
+ val VELOX_HASHMAP_ABANDON_BUILD_DUPHASH_MIN_ROWS =
+ buildConf("spark.gluten.velox.abandonbuild.noduphashminrows")
+ .internal()
+ .doc("Experimental: abandon hashmap build if duplicated rows more than
this number.")
Review Comment:
Should add `experimental()` method and re-generate configuration doc if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
