Zouxxyy commented on code in PR #10763:
URL:
https://github.com/apache/incubator-gluten/pull/10763#discussion_r2371718074
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/transition/package.scala:
##########
@@ -65,11 +65,11 @@ package object transition {
}
}
- // Extractor for Gluten's C2C
+ // Extractor for Gluten's C2C with different convention
object ColumnarToColumnarLike {
def unapply(plan: SparkPlan): Option[SparkPlan] = {
plan match {
- case c2c: ColumnarToColumnarTransition =>
+ case c2c: ColumnarToColumnarTransition if !c2c.isSameConvention =>
Review Comment:
`ColumnarToColumnarLike` is used by the Coster to calculate C2C costs.
Previously, `VeloxResizeBatchesExec` didn't inherit from
`ColumnarToColumnarTransition`, so it wasn't included in the cost calculation.
This change is to maintain the previous behavior.
Besides, in my testing, without this, `ELECT max(l_orderkey) FROM lineitem`
will not generate a `VeloxResizeBatchesExec` node because it is eliminated
after the cost calculation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
