lgbo-ustc commented on code in PR #10815:
URL:
https://github.com/apache/incubator-gluten/pull/10815#discussion_r2415491054
##########
cpp-ch/local-engine/Common/QueryContext.cpp:
##########
@@ -71,7 +74,16 @@ void QueryContext::resetGlobal()
void QueryContext::reset()
{
+ for (auto it = active_executors_.begin(); it != active_executors_.end();
++it)
+ {
+ auto * executor = *it;
+ executor->cancel();
+ std::cerr << "Not closed LocalExecutor:\n" << executor->dumpPipeline()
<< std::endl;
+ delete executor;
Review Comment:
there are raw pointers, not shared_ptr
##########
cpp-ch/local-engine/Common/QueryContext.cpp:
##########
@@ -71,7 +74,16 @@ void QueryContext::resetGlobal()
void QueryContext::reset()
{
+ for (auto it = active_executors_.begin(); it != active_executors_.end();
++it)
+ {
+ auto * executor = *it;
+ executor->cancel();
+ std::cerr << "Not closed LocalExecutor:\n" << executor->dumpPipeline()
<< std::endl;
+ delete executor;
Review Comment:
these are raw pointers, not shared_ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
