kevinwilfong commented on code in PR #10697:
URL:
https://github.com/apache/incubator-gluten/pull/10697#discussion_r2373365555
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxIteratorApi.scala:
##########
@@ -49,9 +50,25 @@ import scala.collection.JavaConverters._
class VeloxIteratorApi extends IteratorApi with Logging {
+ private def setFileSchemaForLocalFiles(
+ localFilesNode: LocalFilesNode,
+ dataSchema: StructType,
Review Comment:
Sure, I chose dataSchema to be consistent with the ScanExecTransformer API,
but you're right, by the time it gets down here fileSchema is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
