liujiayi771 commented on PR #10850: URL: https://github.com/apache/incubator-gluten/pull/10850#issuecomment-3382110881
I believe that checking if osName `contains` some string is sufficient for matching. However, for osVersion, we need more precise matching. Currently, `startsWith` seems appropriate since there might be minor version numbers (e.g., CentOS 8.x or ), or cases like alinux that may include additional parenthetical information (e.g., 3 (OpenAnolis Edition)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
