PHILO-HE commented on code in PR #10793:
URL:
https://github.com/apache/incubator-gluten/pull/10793#discussion_r2386549567
##########
docs/developers/NewToGluten.md:
##########
@@ -345,26 +221,24 @@ After the above installation, you can optionally do some
configuration in Visual
4. Placement of Non-Native Code UTs: Ensure that unit tests for non-native
code are placed within org.apache.gluten and org.apache.spark packages.
This is important because the CI system runs unit tests from these two
paths in parallel. Placing tests in other paths might cause your tests to be
ignored.
-### View surefire reports of Velox ut in GHA
+#### View Surefire reports of Velox unit tests in GHA
Surefire reports are invaluable tools in the ecosystem of Java-based
applications that utilize the Maven build automation tool.
These reports are generated by the Maven Surefire Plugin during the testing
phase of your build process.
They compile results from unit tests, providing detailed insights into which
tests passed or failed, what errors were encountered, and other essential
metrics.
Surefire reports play a crucial role in the development and maintenance of
high-quality software.
-We provide surefire reports of Velox ut in GHA, and developers can leverage
surefire reports with early bug detection and quality assurance.
-
-You can check surefire reports:
+We provide surefire reports of Velox ut in GHA, and developers can leverage
urefire reports with early bug detection and quality assurance.
Review Comment:
I reworded this sentence with "In GitHub Actions, we expose Surefire test
reports so developers can review error messages and stack traces from failing
unit tests". It reads more naturally. Please help check again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
