wangyum commented on code in PR #10916:
URL:
https://github.com/apache/incubator-gluten/pull/10916#discussion_r2446858280
##########
backends-velox/src/test/scala/org/apache/gluten/execution/DynamicOffHeapSizingSuite.scala:
##########
@@ -70,4 +70,38 @@ class DynamicOffHeapSizingSuite extends
VeloxWholeStageTransformerSuite {
runAndCompare(query)
}
}
+
+ test("Dynamic off-heap sizing with setting offheap") {
+ withSQLConf(
+ GlutenCoreConfig.SPARK_OFFHEAP_ENABLED_KEY -> "false") {
+ if (DynamicOffHeapSizingMemoryTarget.isJava9OrLater()) {
Review Comment:
```
Error: Failed to execute goal
com.diffplug.spotless:spotless-maven-plugin:2.27.2:check (spotless-check) on
project backends-velox: The following files had format violations:
Error:
src/test/scala/org/apache/gluten/execution/DynamicOffHeapSizingSuite.scala
Error: @@ -72,8 +72,7 @@
Error: ??}
Error:
Error: ??test("Dynamic?off-heap?sizing?with?setting?offheap")?{
Error: -????withSQLConf(
Error:
-??????GlutenCoreConfig.SPARK_OFFHEAP_ENABLED_KEY?->?"false")?{
Error:
+????withSQLConf(GlutenCoreConfig.SPARK_OFFHEAP_ENABLED_KEY?->?"false")?{
Error:
??????if?(DynamicOffHeapSizingMemoryTarget.isJava9OrLater())?{
Error: ????????val?query?=
Error: ??????????"""
Error: Run 'mvn spotless:apply' to fix these violations.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
