PHILO-HE commented on code in PR #11056:
URL:
https://github.com/apache/incubator-gluten/pull/11056#discussion_r2520926605
##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -336,7 +336,7 @@ std::unique_ptr<VeloxBackend> VeloxBackend::instance_ =
nullptr;
void VeloxBackend::create(
std::unique_ptr<AllocationListener> listener,
const std::unordered_map<std::string, std::string>& conf) {
- instance_ = std::unique_ptr<VeloxBackend>(new
VeloxBackend(std::move(listener), conf));
+ instance_ = std::make_unique<VeloxBackend>(std::move(listener), conf);
Review Comment:
Thanks for your PR. It appears that this is not applicable for private
constructor. Maybe, we have to keep using the original implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
