Yohahaha commented on code in PR #11083:
URL:
https://github.com/apache/incubator-gluten/pull/11083#discussion_r2540189989
##########
cpp/core/shuffle/PartitionWriter.h:
##########
@@ -48,7 +48,12 @@ class PartitionWriter : public Reclaimable {
~PartitionWriter() override = default;
- virtual arrow::Status stop(ShuffleWriterMetrics* metrics) = 0;
+ void acceptMetrics(ShuffleWriterMetrics* metrics) {
Review Comment:
use metrics member to count written bytes per batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
