zhli1142015 commented on PR #11101: URL: https://github.com/apache/incubator-gluten/pull/11101#issuecomment-3552080405
> Thank for the fix. Can you add a comment to header file and comment > > pageNumber_ 13bit pageCursor_ 27bit row2Partition_ vector of 24bit > Done. We ran into an issue where the number of pages exceeded 8,192. From the code, the maximum memory per page is 64 MB, which is a hard-coded limit, so it shouldn’t exceed the 128 MB cap here. The number of partitions theoretically shouldn’t exceed 16 million. Therefore, this change didn’t add additional checks, although having similar checks would indeed be beneficial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
