jinchengchenghh commented on code in PR #11205:
URL:
https://github.com/apache/incubator-gluten/pull/11205#discussion_r2570994647
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -221,7 +230,8 @@ object VeloxBackendSettings extends BackendSettingsApi {
val validationChecks = Seq(
validateScheme(),
- validateFormat(),
+ validateFormat(format),
Review Comment:
Do we still need validateFormat? Looks like validatePartitionFormat is
enough.
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/hive/HiveTableScanExecTransformer.scala:
##########
@@ -113,6 +116,9 @@ case class HiveTableScanExecTransformer(
@transient private lazy val partitions: Seq[Partition] =
partitionWithReadFileFormats.unzip._1
+ @transient private lazy val distinctReadFileFormatsCache:
Set[ReadFileFormat] =
Review Comment:
distinctReadFileFormatsCache -> distinctReadFileFormats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
