zhouyuan commented on code in PR #11134:
URL:
https://github.com/apache/incubator-gluten/pull/11134#discussion_r2589712265
##########
gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -551,6 +551,11 @@ object GlutenConfig extends ConfigRegistry {
nativeConfMap
.put(SQLConf.LEGACY_TIME_PARSER_POLICY.key,
v.toUpperCase(Locale.ROOT)))
+ // put in all gluten velox configs
+ conf
+ .filter(_._1.startsWith(s"spark.gluten.$backendName"))
+ .foreach(entry => nativeConfMap.put(entry._1, entry._2))
+
// Backend's dynamic session conf only.
val confPrefix = prefixOf(backendName)
Review Comment:
The code should be work for the hash build dedup feature. However for now
Gluten actually does not have a clear boundary on session level vs. static
config, I guess we may need some refactor on this part in future work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
