EpsilonPrime opened a new pull request, #11277:
URL: https://github.com/apache/incubator-gluten/pull/11277
This option has been unused since October 2023 when the filter push-down
framework was refactored in PR #3301 (commit a03e2b3).
History:
- Added in PR #2457 (Aug 2023) to enable row group filtering based on
min/max statistics in Parquet files
- Removed from C++ backend in PR #3301 (Oct 2023) during filter push-down
refactor, only 2.5 months after initial implementation
- Replaced by more sophisticated page-level filtering in PR #4634 (Mar 2024)
which uses Parquet Page Index
The configuration option and proto field were left as dead code:
- Default value was always false (disabled)
- C++ backends (both ClickHouse and Velox) never accessed this field
- Modern Parquet readers enable row group filtering by default
This removes:
- ParquetReadOptions.enable_row_group_maxmin_index proto field
- spark.gluten.sql.parquet.maxmin.index configuration option
- All references in LocalFilesNode.java and IcebergLocalFilesNode.java
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/incubator-gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
