liujiayi771 opened a new pull request, #11295:
URL: https://github.com/apache/incubator-gluten/pull/11295

   ## What changes are proposed in this pull request?
   
   This PR adds a fallback mechanism to attempt retrieving the fallback reason 
from a SparkPlan node's tags when its `logicalLink` is unavailable. Some 
SparkPlan nodes, such as the `SortExec` generated by Spark's 
`EnsureRequirements` rule, inherently lack a `logicalLink`. Furthermore, some 
plan conversion rules in Gluten might omit calling `copyTagsFrom`, leading to 
the loss of the original `logicalLink`.
   
   In such cases, if the node falls back, the fallback reason might be stored 
within the node's tags. This change attempts to retrieve the reason from there 
as a best-effort approach.
   
   ## How was this patch tested?
   Add a test case when window sort fallback. Before this change, the fallback 
reason was a generic "Gluten does not touch it or does not support it". After 
the change, it can display a more precise reason, such as 
"[FallbackByUserOptions] Validation failed on node Sort", which is retrieved 
from the physical node's tags.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to