lgbo-ustc commented on code in PR #11299:
URL: 
https://github.com/apache/incubator-gluten/pull/11299#discussion_r2638419642


##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -1385,10 +1385,10 @@ class ClickHouseTestSettings extends 
BackendTestSettings {
     .includeCH("Spark vectorized reader - with partition data column - select 
a single complex field and is null expression in project")
     .includeCH("Non-vectorized reader - without partition data column - select 
a single complex field and is null expression in project")
     .includeCH("Non-vectorized reader - with partition data column - select a 
single complex field and is null expression in project")
-    .includeCH("Spark vectorized reader - without partition data column - 
select nested field from a complex map key using map_keys")
-    .includeCH("Spark vectorized reader - with partition data column - select 
nested field from a complex map key using map_keys")
-    .includeCH("Non-vectorized reader - without partition data column - select 
nested field from a complex map key using map_keys")
-    .includeCH("Non-vectorized reader - with partition data column - select 
nested field from a complex map key using map_keys")
+    .exclude("Spark vectorized reader - without partition data column - select 
nested field from a complex map key using map_keys")

Review Comment:
   FYI
   Map key field must be primitive in parquet reader
   ```
   Caused by: org.apache.gluten.exception.GlutenException: Map key field must 
be primitive: (in file/uri 
/data3//docker/local_gluten/spark-3.3.2-bin-hadoop3/spark-warehouse/tm1/part-00000-fe984e75-ebaa-4b8e-a98a-1e82309c3199-c000.snappy.parquet):
 While executing SubstraitFileSource
   0. ./contrib/llvm-project/libcxx/include/__exception/exception.h:113: 
Poco::Exception::Exception(String const&, int) @ 0x000000001d963432
   1. ./build/./src/Common/Exception.cpp:128: 
DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 
0x00000000100ab1de
   2. ./src/Common/Exception.h:123: DB::Exception::Exception(String&&, int, 
String, bool) @ 0x00000000083fd40e
   3. ./src/Common/Exception.h:58: 
DB::Exception::Exception(PreformattedMessage&&, int) @ 0x00000000083fd000
   4. ./src/Common/Exception.h:141: DB::Exception::Exception<>(int, 
FormatStringHelperImpl<>) @ 0x00000000083dd86b
   5. 
./build/./src/Processors/Formats/Impl/Parquet/ParquetColumnReaderFactory.cpp:997:
 DB::ColumnReaderBuilder::buildReader(std::shared_ptr<parquet::schema::Node>, 
std::shared_ptr<DB::IDataType const> const&, int, int, bool) @ 
0x0000000018a5eb28
   6. ./build/./src/Processors/Formats/Impl/Parquet/RowGroupChunkReader.cpp:73: 
DB::RowGroupChunkReader::RowGroupChunkReader(DB::ParquetReader*, unsigned long, 
std::shared_ptr<DB::RowGroupPrefetch>, std::shared_ptr<DB::RowGroupPrefetch>, 
std::unordered_map<String, std::shared_ptr<DB::ColumnFilter>, 
std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String 
const, std::shared_ptr<DB::ColumnFilter>>>>) @ 0x0000000018a4c0fd
   7. ./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:634: 
std::__unique_if<DB::RowGroupChunkReader>::__unique_single 
std::make_unique[abi:ne190107]<DB::RowGroupChunkReader, DB::ParquetReader*, 
unsigned long&, std::shared_ptr<DB::RowGroupPrefetch>, 
std::shared_ptr<DB::RowGroupPrefetch>, std::unordered_map<String, 
std::shared_ptr<DB::ColumnFilter>, std::hash<String>, std::equal_to<String>, 
std::allocator<std::pair<String const, 
std::shared_ptr<DB::ColumnFilter>>>>&>(DB::ParquetReader*&&, unsigned long&, 
std::shared_ptr<DB::RowGroupPrefetch>&&, 
std::shared_ptr<DB::RowGroupPrefetch>&&, std::unordered_map<String, 
std::shared_ptr<DB::ColumnFilter>, std::hash<String>, std::equal_to<String>, 
std::allocator<std::pair<String const, std::shared_ptr<DB::ColumnFilter>>>>&) @ 
0x00000000189b2d0e
   8. ./build/./src/Processors/Formats/Impl/Parquet/ParquetReader.cpp:115: 
DB::ParquetReader::getRowGroupChunkReader(unsigned long, 
std::shared_ptr<DB::RowGroupPrefetch>, std::shared_ptr<DB::RowGroupPrefetch>) @ 
0x00000000189b2205
   9. ./build/./src/Processors/Formats/Impl/Parquet/ParquetReader.cpp:137: 
std::unique_ptr<DB::RowGroupChunkReader, 
std::default_delete<DB::RowGroupChunkReader>> 
std::__function::__policy_invoker<std::unique_ptr<DB::RowGroupChunkReader, 
std::default_delete<DB::RowGroupChunkReader>> (unsigned long, 
std::shared_ptr<DB::RowGroupPrefetch>, 
std::shared_ptr<DB::RowGroupPrefetch>)>::__call_impl[abi:ne190107]<std::__function::__default_alloc_func<DB::ParquetReader::getSubRowGroupRangeReader(std::vector<int,
 std::allocator<int>>)::$_0, std::unique_ptr<DB::RowGroupChunkReader, 
std::default_delete<DB::RowGroupChunkReader>> (unsigned long, 
std::shared_ptr<DB::RowGroupPrefetch>, 
std::shared_ptr<DB::RowGroupPrefetch>)>>(std::__function::__policy_storage 
const*, unsigned long, std::shared_ptr<DB::RowGroupPrefetch>&&, 
std::shared_ptr<DB::RowGroupPrefetch>&&) @ 0x00000000189b2b33
   10. ./contrib/llvm-project/libcxx/include/__functional/function.h:716: ? @ 
0x00000000189b3128
   11. ./build/./src/Processors/Formats/Impl/Parquet/ParquetReader.cpp:199: 
DB::SubRowGroupRangeReader::loadRowGroupChunkReaderIfNeeded() @ 
0x00000000189b2aa8
   ```
   
   But ORC supports



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to