zhouyuan commented on code in PR #11304:
URL:
https://github.com/apache/incubator-gluten/pull/11304#discussion_r2638841411
##########
backends-velox/src-iceberg-spark34/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1994,11 +1994,13 @@ public void testFilesTablePartitionId() {
.mode("append")
.save(loadLocation(tableIdentifier));
+ // spotless:off
Review Comment:
@jinchengchenghh
In spotless check it's using regex to match all the test code:
https://github.com/apache/incubator-gluten/blob/main/pom.xml#L717
so even if we dont enable spark-34 profile it will also do the style check
always. in this patch we introduced a new format in java-21 profile so it
introduced some conflicts. I fired one issue to track on this:
https://github.com/apache/incubator-gluten/issues/11321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
