PHILO-HE commented on code in PR #11120: URL: https://github.com/apache/incubator-gluten/pull/11120#discussion_r2652708714
########## .github/workflows/cpp_clang_tidy.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Clang Tidy Check + +on: + workflow_run: + workflows: ["Velox Backend (x86)"] Review Comment: With workflow_run, it seems this new workflow will be triggered after merged to main branch. ########## .github/workflows/cpp_clang_tidy.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Clang Tidy Check + +on: + workflow_run: + workflows: ["Velox Backend (x86)"] + types: + - completed + +env: + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + MVN_CMD: 'mvn -ntp' + WGET_CMD: 'wget -nv' + SETUP: 'source .github/workflows/util/setup-helper.sh' + CCACHE_DIR: "${{ github.workspace }}/.ccache" + # spark.sql.ansi.enabled defaults to false. + SPARK_ANSI_SQL_MODE: false Review Comment: Ditto for the above line 26-29. ########## .github/workflows/cpp_clang_tidy.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Clang Tidy Check + +on: + workflow_run: + workflows: ["Velox Backend (x86)"] + types: + - completed + +env: + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + MVN_CMD: 'mvn -ntp' + WGET_CMD: 'wget -nv' + SETUP: 'source .github/workflows/util/setup-helper.sh' + CCACHE_DIR: "${{ github.workspace }}/.ccache" + # spark.sql.ansi.enabled defaults to false. + SPARK_ANSI_SQL_MODE: false Review Comment: Remove this since not used in this workflow. ########## .github/workflows/cpp_clang_tidy.yml: ########## @@ -0,0 +1,78 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Clang Tidy Check + +on: + workflow_run: + workflows: ["Velox Backend (x86)"] + types: + - completed + +env: + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + MVN_CMD: 'mvn -ntp' + WGET_CMD: 'wget -nv' + SETUP: 'source .github/workflows/util/setup-helper.sh' + CCACHE_DIR: "${{ github.workspace }}/.ccache" + # spark.sql.ansi.enabled defaults to false. + SPARK_ANSI_SQL_MODE: false + +concurrency: + group: clang-tidy-${{ github.event.workflow_run.id }} + cancel-in-progress: true + +jobs: + clang-tidy-check: + runs-on: ubuntu-22.04 + container: apache/gluten:centos-8-jdk8 + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + ref: ${{ github.event.workflow_run.head_sha }} + - name: Check for cpp files changes + id: filter + run: | + cd $GITHUB_WORKSPACE/ + git fetch --depth=2 origin + if git show --name-only --format="" HEAD 2>/dev/null | grep -q -E '^cpp/.*\.(cc|h)$'; then Review Comment: It seems only HEAD will be checked? In pull request branch, the cpp code changes can be made ahead of HEAD, which will be missed by this code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
