Angryrou opened a new pull request, #11345:
URL: https://github.com/apache/incubator-gluten/pull/11345
Previous includeAllGlutenTests and excludeAllGlutenTests methods are using
exact match instead of prefix matching, which contradicts what it intended to
do.
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/incubator-gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
Correct the `includeAllGlutenTests` and `excludeAllGlutenTests` methods to
use prefix to match instead of using exact match.
```
def includeAllGlutenTests(): SuiteSettings = {
settings.includeByPrefix(GLUTEN_TEST) // was
settings.include(GLUTEN_TEST)
settings
}
def excludeAllGlutenTests(): SuiteSettings = {
settings.excludeByPrefix(GLUTEN_TEST) // was
settings.exclude(GLUTEN_TEST)
settings
}
```
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
Will enable many tests in VeloxAdaptiveQueryExecSuite and
ClickHouseAdaptiveQueryExecSuite where `includeAllGlutenTests` is used to
filter tests.
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
