marin-ma commented on code in PR #11252:
URL: 
https://github.com/apache/incubator-gluten/pull/11252#discussion_r2664598532


##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala:
##########
@@ -155,7 +155,7 @@ trait UnaryTransformSupport extends TransformSupport with 
UnaryExecNode {
 }
 
 case class WholeStageTransformer(child: SparkPlan, materializeInput: Boolean = 
false)(
-    val transformStageId: Int
+    var transformStageId: Int

Review Comment:
   When AQE is on, `transformStageId` always starts at 0 within each query 
stage. In this case `transformStageId` is not globally unique within the whole 
plan tree. After all query stages have been executed, the 
`RegenerateTransformStageId` rule traverses the whole plan tree and updates 
this value incrementally to a unique id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to